Compare commits

...

2 Commits

Author SHA1 Message Date
Jean-Marc ANDRE
6678bc50e1 don't need to log BackupConfiguration not found 2023-04-20 10:40:04 +02:00
Jean-Marc ANDRE
0175496bb8 delete rolebindings 2023-04-20 10:39:20 +02:00
2 changed files with 5 additions and 3 deletions

View File

@ -290,7 +290,7 @@ func (r *BackupConfigurationReconciler) addSidecar(backupConf formolv1alpha1.Bac
// Delete the sidecar role is there is no more sidecar container in the namespace
func (r *BackupConfigurationReconciler) deleteRBAC() error {
for _, roleBindingName := range []string{FORMOL_BS_CREATOR_ROLEBINDING, FORMOL_SIDECAR_CLUSTERROLEBINDING} {
for _, roleBindingName := range []string{FORMOL_BS_CREATOR_ROLEBINDING, FORMOL_SIDECAR_ROLEBINDING} {
roleBinding := rbacv1.RoleBinding{}
if err := r.Get(r.Context, client.ObjectKey{
Namespace: r.Namespace,
@ -301,7 +301,7 @@ func (r *BackupConfigurationReconciler) deleteRBAC() error {
}
}
}
for _, roleName := range []string{FORMOL_BS_CREATOR_ROLE, FORMOL_SIDECAR_CLUSTERROLE} {
for _, roleName := range []string{FORMOL_BS_CREATOR_ROLE, FORMOL_SIDECAR_ROLE} {
role := rbacv1.Role{}
if err := r.Get(r.Context, client.ObjectKey{
Namespace: r.Namespace,

View File

@ -62,7 +62,9 @@ func (r *BackupSessionReconciler) Reconcile(ctx context.Context, req ctrl.Reques
Namespace: backupSession.Spec.Ref.Namespace,
Name: backupSession.Spec.Ref.Name,
}, &backupConf); err != nil {
r.Log.Error(err, "unable to get BackupConfiguration")
if !errors.IsNotFound(err) {
r.Log.Error(err, "unable to get BackupConfiguration")
}
return ctrl.Result{}, err
}
if !backupSession.ObjectMeta.DeletionTimestamp.IsZero() {