backup / restore of OnlineKind and JobKind work

controllers/backupconfiguration_controller_helpers.go

@@ -154,7 +154,7 @@ func (r *BackupConfigurationReconciler) DeleteSidecar(backupConf formolv1alpha1.
 		Namespace: backupConf.Namespace,
 		Name:      backupConf.Spec.Repository,
 	}, &repo); err != nil {
-		r.Log.Error(err, "unable to get Repo")
+		r.Log.Error(err, "unable to get Repo", "repo", backupConf.Spec.Repository)
 		return err
 	}
 	r.Log.V(1).Info("Got Repository", "repo", repo)

test/02-backupconf.yaml

@@ -24,25 +24,6 @@ spec:
 ---
 apiVersion: formol.desmojim.fr/v1alpha1
 kind: Function
-metadata:
-  name: restore-pg
-  namespace: demo
-spec:
-  name: restore-pg
-  image: desmo999r/formolcli:latest
-  args: ["postgres", "restore", "--hostname", $(PGHOST), "--database", $(PGDATABASE), "--username", $(PGUSER), "--password", $(PGPASSWD), "--file", "/output/backup-pg.sql"]
-  env:
-    - name: PGHOST
-      value: postgres
-    - name: PGDATABASE
-      value: demopostgres
-    - name: PGUSER
-      value: demopostgres
-    - name: PGPASSWD
-      value: password123!
----
-apiVersion: formol.desmojim.fr/v1alpha1
-kind: Function
 metadata:
   name: with-envfrom
   namespace: demo
@@ -80,6 +61,20 @@ spec:
 ---
 apiVersion: formol.desmojim.fr/v1alpha1
 kind: Function
+metadata:
+  name: restore-pg
+  namespace: demo
+spec:
+  name: restore-pg
+  image: desmo999r/formolcli:latest
+  command: ["psql"]
+  args: ["--username", $(PGUSER), "--quiet", "--file", "/formol-shared/backup-pg.sql", "postgres"]
+  env:
+    - name: PGUSER
+      value: demopostgres
+---
+apiVersion: formol.desmojim.fr/v1alpha1
+kind: Function
 metadata:
   name: maintenance-off
   namespace: demo
@@ -132,7 +127,7 @@ spec:
     containers:
       - name: postgres
         job:
-          - name: backup-pg
+          - name: pg
 #  - kind: Job
 #    name: backup-pg
 #    steps: