From a55046f3d7a0ab55cfdfac12327660d23770fc34 Mon Sep 17 00:00:00 2001
From: Jean-Marc Andre <jandre@desmojim.fr>
Date: Wed, 17 Feb 2021 22:12:00 +0100
Subject: [PATCH] update status when needed only

---
 controllers/restoresession_controller.go | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/controllers/restoresession_controller.go b/controllers/restoresession_controller.go
index 8f3d95b..c9734b7 100644
--- a/controllers/restoresession_controller.go
+++ b/controllers/restoresession_controller.go
@@ -194,6 +194,10 @@ func (r *RestoreSessionReconciler) StatusUpdate() error {
 		case formolv1alpha1.Failure:
 			log.V(0).Info("last restore task failed. Stop here", "target", currentTargetStatus.Name)
 			r.RestoreSession.Status.SessionState = formolv1alpha1.Failure
+			if err := r.Status().Update(ctx, r.RestoreSession); err != nil {
+				log.Error(err, "unable to update restoresession")
+				return err
+			}
 		case formolv1alpha1.Running:
 			log.V(0).Info("task is still running", "target", currentTargetStatus.Name)
 			return nil
@@ -206,13 +210,13 @@ func (r *RestoreSessionReconciler) StatusUpdate() error {
 			if targetStatus == nil {
 				// No more task to start. The restore is over
 				r.RestoreSession.Status.SessionState = formolv1alpha1.Success
+				if err := r.Status().Update(ctx, r.RestoreSession); err != nil {
+					log.Error(err, "unable to update restoresession")
+					return err
+				}
 			}
 		}
 	}
-	if err := r.Status().Update(ctx, r.RestoreSession); err != nil {
-		log.Error(err, "unable to update restoresession")
-		return err
-	}
 	return nil
 }